Support UNIX domain socket in the example servers #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achew22
approved these changes
Apr 20, 2018
examples/proto_error_test.go
Outdated
| defer cancel() | ||
|
|
||
| // Waiting for the server's getting available. | ||
| // TODO(yugui) find a better way to wait |
There was a problem hiding this comment.
:-)
True. But let me work on it in another PR.
yugui
force-pushed
the
example/unix-domain-socket
branch
2 times, most recently
from
470620c
to
eed05d1
Compare
yugui
force-pushed
the
example/unix-domain-socket
branch
from
eed05d1
to
a31262a
Compare
|
Build fixed. Could you take another look? |
yugui
added a commit
that referenced
this pull request
Apr 27, 2018
Wait for the gateway server to get ready. #609 (comment)
yugui
added a commit
that referenced
this pull request
Apr 27, 2018
Wait for the gateway server to get ready. #609 (comment)
yugui
added a commit
that referenced
this pull request
Apr 27, 2018
Wait for the gateway server to get ready. #609 (comment)
yugui
added a commit
that referenced
this pull request
Apr 27, 2018
Wait for the gateway server to get ready. #609 (comment)
achew22
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Avoid timing issues in the integration tests Wait for the gateway server to get ready. #609 (comment)
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* Lets example servers gracefully shutdown * Support UNIX domain sockets in the example servers
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* Avoid timing issues in the integration tests Wait for the gateway server to get ready. grpc-ecosystem#609 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #451